ConsumeWorker: improve bank check/switch efficiency#8291
ConsumeWorker: improve bank check/switch efficiency#8291apfitzge merged 3 commits intoanza-xyz:masterfrom
Conversation
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8291 +/- ##
=========================================
- Coverage 83.2% 83.2% -0.1%
=========================================
Files 841 836 -5
Lines 368895 366658 -2237
=========================================
- Hits 307201 305249 -1952
+ Misses 61694 61409 -285 🚀 New features to boost your workflow:
|
alessandrod
left a comment
alessandrod
left a comment
There was a problem hiding this comment.
PR looks good, just nit on a method name
| self.shared_working_bank.load() | ||
| /// Update the bank if it has changed. | ||
| /// Returns true if the bank is updated or still usable. | ||
| fn update_bank(&self, bank: &mut Arc<Bank>) -> bool { |
There was a problem hiding this comment.
nit: when I started reviewing I found this name confusing, since in most of the
calls it returns the current bank it doesn't update? maybe call it
update_working_bank_if_needed or something?
(cherry picked from commit a58c605) # Conflicts: # core/src/replay_stage.rs
3 participants
Problem
Arc::ptr_eqthat needs to be fixedSummary of Changes
Arc::cloneon actual bank switch.Fixes #